Skip to content

Conversation

@Chenyaaang
Copy link
Collaborator

@Chenyaaang Chenyaaang commented Oct 3, 2025

Description

Make changes on tpu_commons side according to vllm's vllm-project/vllm#25893

Tests

Checklist

Before submitting this PR, please make sure:

  • I have performed a self-review of my code.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have made or will make corresponding changes to any relevant documentation.

@github-actions
Copy link

github-actions bot commented Oct 3, 2025

Description

Start with a short description of what the PR does and how this is a change from
the past.

The rest of the description includes relevant details and context, examples:

  • why is this change being made,
  • the problem being solved and any relevant context,
  • why this is a good solution,
  • some information about the specific implementation,
  • shortcomings of the solution and possible future improvements.

If the change fixes a bug or a Github issue, please include a link, e.g.,:
FIXES: b/123456
FIXES: #123456

Tests

Please describe how you tested this change, and include any instructions and/or
commands to reproduce.

Checklist

Before submitting this PR, please make sure:

  • I have performed a self-review of my code.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have made or will make corresponding changes to any relevant documentation.

@Chenyaaang Chenyaaang marked this pull request as draft October 3, 2025 18:20
Signed-off-by: Chenyaaang <chenyangli@google.com>
@Chenyaaang Chenyaaang marked this pull request as ready for review October 3, 2025 19:10
@Chenyaaang Chenyaaang merged commit 4304a6d into main Oct 3, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants